feat: publish asset-manifest v1 from Recast, Repaint and Outpaint sidecars - #69
Merged
Conversation
…ecars Shot-aware Recast, Repaint and Outpaint keep gallery keys and now write the canonical sidecar through publish_generation_sidecar, without inventing actor.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0356c8d. Configure here.
AST-extracted Recast/Repaint/Outpaint tests do not inherit module globals.
Owner
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 74da8b4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente writer de manifiesto: solo Recast / Repaint / Outpaint shot-aware.
publish_generation_sidecarjob.workspace_launch_runtime.pyVerificación local
test_execution_mode+test_asset_manifest+test_architecture_contracts: 38 passedPendiente de CI.
@cursor reviewsobre este HEAD.Note
Medium Risk
Touches generation output metadata for three edit tools in
_launch_runtime.py, which affects restore/republish behavior but follows an established manifest API with new tests.Overview
Recast, Repaint, and Outpaint shot-aware sidecar writers no longer write raw
.meta.jsonwithjson.dump; they now callpublish_generation_sidecarwithworkspace_idfrom the job and a fixedtool(recast|repaint|outpaint).That aligns these edit flows with the shared asset-manifest v1 path (same as other generation sidecars): sanitized restorable params still land in the sidecar payload, but publication also records origin/execution metadata with
actor: unknownand no invented Story/Series identity.Tests add parametrized coverage for all three writers (private temp keys stripped, secrets not persisted, stable asset id on rewrite, new id per artifact) and extend the architecture contract so these functions must use
publish_generation_sidecarand must not calljson.dumpdirectly.Reviewed by Cursor Bugbot for commit 74da8b4. Configure here.